Hi Jim, FWIW I built it and ran the basic tests (make check) without any errors on Debian GNU/Linux unstable. I don't have access to any other systems or hardware architectures for more interesting t
AFAIK, I am the only one who has built the latest snapshot: http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/17604 Though it's been only two days. Unless I hear of new bug reports or portabilit
checks pass on Fedora 11 and Ubuntu 7.10 2 failures on Fedora Core 5 due to copy::utimensat_if_possible() failing with: $ (cd tests && make check TESTS=cp/abuse VERBOSE=yes) cp: preserving times for
Sorry for the delay, got busy. I just built & make check, and got two errors. First one is here, I will re-run the second error by itself in a few. Running on Ubuntu 9.10 (kernel 2.6.31.5 with Ubuntu
So tail silently returns with 1 immediately. The only way I can see this happening is in tail_forever_inotify() at: if (follow_mode == Follow_descriptor && !found_watchable) return; We should probabl
Heh. Please let me help you get distracted ;-) Second error, also on tail: FAIL: tail-2/pid (exit: 1) == + tail --version tail (GNU coreutils) 7.4.115-c9c92 Copyright (C) 2009 Free Software Foundatio
Yet another one, on check-root. I am starting to wonder if this may be a problem with my setup, since nobody has reported errors on tail. FAIL: tail-2/append-only (exit: 1) == + tail --version tail (
Meeting over :) Following from the above analysis, does the attached help? cheers, Pádraig. * src/tail.c (tail_inotify_forever): Use the correct bounds in the error check of the return from inotify_
While I'm at it here's a patch to improve that test. cheers, Pádraig. * tests/tail-2/pid: Speed up the test by specifying a timeout of 100ms rather than the default 1s. Also instead of failing in th
Thanks, Pádraig. Building & testing right now both of them on the snapshot; then on git. Attachment: signature.asc Description: This is a digitally signed message part
OK. Both tests now succeed on the snapshot. I will apply them to git now (where I also had the same error). Cheers, ..C.. Attachment: signature.asc Description: This is a digitally signed message par
Thanks for the reports. How did you run those tests? When I do it like this (per README), they all pass. sudo env PATH="$PATH" NON_ROOT_USERNAME=$USER make -k check-root
Yes, I did run them this way. I have just re-run them under git master (so that I would have the current status, without Pádraig's fixes). It failed the same. The following is the command line I use
These highlighted a couple of issue I think on systems without utimensat(). 1. The symlink _target_ gets its time updated 2. If 1 fails then the process returns a failure I've fixed both in the attac
Ten lines above that, we ensure that 0 <= f[i].wd is true, so this stmt: if (follow_mode == Follow_name || 0 <= f[i].wd) is equivalent to this: if (follow_mode == Follow_name || true) aka, if (true)
Agreed. I'll push the attached soon. cheers, Pádraig. * src/tail.c (tail_forever_inotify): Remove the redundant and incorrect error check of the return from inotify_add_watch(). Also initialize the