Increased the header buffer to 8Kb, as there are no limits to the size of field name, values or headers themselves. While the current value is big enough, other projects such as Apache [1] or nginx h
[Please CC me directly, as I'm not subscribed to the list.] Yes, thanks. Updated patch is attached. 2015-02-14 Eli Zaretskii <address@hidden> Gisle Vanem <address@hidden> * warc.c (windows_uuid_str)
The patch I suggest is below. It uses the fallback method if Rpcrt4.dll cannot be loaded, or if the functions from that DLL fail for some reason. 2015-02-14 Eli Zaretskii <address@hidden> Gisle Vane
I didn't mean it, but yes, that would be the best solution. Eli Zaretskii already already stated that. IMO, best place would be in warc_init(). That would avoid loading the library if the user does n
That's not really friendly to those who download precompiled binaries, since the situation on the machine where wget was built and where it will be used can be very different. Anyway, Rpcrt4.dll com
Do we still want to support the older Windows NT4 and 9X versions? If so, we should try loading Rpcrt4.dll dynamically, with LoadLibrary, and if that fails, fall back on the current code. Thanks.
I would prefer dynamic linking (-lrpcrt4). If rpcrt4.lib/.dll is *not* a basic windows library, you should check for the library in configure.ac (case "$host_os" in ...). There is an example check: d
And for Windows? I guess the 'UuidCreate()' or 'UuidCreateSequential()' functions from Rpcrt4.dll could be used? I could write a patch for loading Rpcrt4.dll at run-time if there's some interest. Do
Am Sonntag, 21. Dezember 2014, 18:33:06 schrieb Eli Zaretskii: base_name() is a similar function (but I couldn't find a documentation). https://www.gnu.org/software/gnulib/manual/html_node/basename.h
Shouldn't this use base_name? AFAICS, this is what gnulib provides. And likewise here. Otherwise, looks good, except that you need to leave fcntl.h there, as I wrote earlier. Thanks!
I don't think you can drop it, because warc.c uses O_TEMPORARY, which is defined on fcntl.h, and its value is not zero. Will do. I meant in "Wgetrc Commands" node in the Info manual. IOW, this is no
Hi Eli, \usr\bin\../lib/gcc/mingw32/4.7.2/../../../../include/string.h:92:39: Right, we have two issues. But using basename from gnulib increases overall compatibility *AND* also fixes your issue reg
The MinGW implementation indeed writes into its argument string. However, warc.c already handles this contingency, and works on a copy of the argument passed to warc_write_record. So I see no proble
Hi Eli, thanks for your detailed report(s) ! See my answers inline. Tim The man page for basename says that there is a POSIX-2001 and a GNU version. The POSIX version does not allow string literals -
(I'm not subscribed to the list, so please CC me on any replies and discussions. Thanks in advance.) I've built wget 1.16.1 with mingw.org's toolchain, and encountered a few issues, described below.
Thanks, your patch has been pushed to git. On top of it I created the attached patch that implements my suggestion from above. Please review and test on OpenBSD if possible. Tim Attachment: 0001-conf