It looks like a good opportunity to fix ./configure's libuuid detection. We just have to agree on an approach. Suggestion: if --with-libuuid explicitly specified search for libuuid (pkg-config or fa
Thanks for looking at it! I think this makes sense and would be a nice addition on any OS that provides those uuid functions natively. Given the following points: - I didn't sign the FSF paperwork th
Thanks for your contribution ! It looks like a good opportunity to fix ./configure's libuuid detection. We just have to agree on an approach. Suggestion: if --with-libuuid explicitly specified search
Hi, in src/warc.c three methods are provided to generate uuids: libuuid, uuid functions from libc, and a fallback method. At least OpenBSD, FreeBSD and NetBSD provide those uuid functions in their li
Tim Ruehsen wrote: Another option would be to completely avoid ngettext() - we just use it at two places (spider.c and warc.c) (ngettext(s1,s2,n) --> n==1?s1:s2). Some languages have plurals way weir
Since Solaris 10 'locale.h' pulls in libintl.h, our '#define ngettext' clashes with the ngettext function. I changed our #define to WG_NGETTEXT (WG_ for the wget namespace). Another option would be t
And use semicolons to separate multiple phrases in a description. -- src/main.c | 280 ++++++++++++++++++++++++++++++-- 1 files changed, 140 insertions(+), 140 deletions(-) diff --git a/src/main.c b/s
We do not need gettext.h. We only need _() and libintl.h inclusion. Here is a patch to address that. Please review and comment. Tim Attachment: 0001-Get-rid-of-gettext.h.patch Description: Text Data
We do not need gettext.h. We only need _() and libintl.h inclusion. Here is a patch to address that. Please review and comment. Tim Attachment: signature.asc Description: This is a digitally signed m
Gisle is right. The current compilation with gcc/linux has also lots of these: gettext.h: In function 'dcpgettext_expr': gettext.h:218:9: warning: implicit declaration of function 'xfree' [- Wimplici
And that is precisely why I've been gunning for getting a good CI setup in place. The above patch worked for me flawlessly, but is causing problems on the MSVC compiler. undefined; That is exactly ho
The recent change [1] to gettext.h of replacing free() with xfree() has generated many warnings on MSVC: cl -nologo -MD ... -c cookies.c g:\mingw32\src\inet\wget\src\gettext.h(218) : warning C4013: '
Hi, Attached is a patch for a missing 'version.h' in wget_SOURCES in the src/Makefile.am, which I suppose should have been included in the above patch by Darshit. Without it, 'make distcheck' fails.
In test.c, this patch changes the type of program_argstring to char * from a const char *. This is because, we use a char * string in the rest of the program and declare an extern accordingly. Removi
Hi Gisle, please always answer to the mailing list. You don't have the latest git version, at least your diff isn't based on it. I pushed the C89 changes right before I asked you to give me the compi
Newer versions of these packages ship with pkg-config files, so if we can detect it via those, do so. If that fails, fall back to the old methods. Also add a configure flag to explicitly control its