[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Adonthell-devel] 0.4 source structure proposals and questions
From: |
Kai Sterker |
Subject: |
Re: [Adonthell-devel] 0.4 source structure proposals and questions |
Date: |
Sun, 2 Mar 2003 19:53:48 +0100 |
On Sun, 02 Mar 2003 19:02:09 +0100 Alexandre Courbot wrote:
> So, here is the base package I've made. It includes the base library
> (actually - only fileops) and the gfx library. I'm using automake 1.7,
> autoconf 2.57, libtool 1.4.2a, python2.2 and SWIG 1.3.17. I've made a
> "make dist" to get this package anyway, so you don't need to
> ./autogen.sh it.
I'll try it out afterwards. Just had a short glance at the
Makefile.am's. Great work, but I still have one or two things to add:
You should add a line like:
# require automake 1.7
AUTOMAKE_OPTIONS = 1.7
There's a similar option for configure.in:
AC_PREREQ(2.50)
Also, when listing multiple dist, source or header files, I think they
should all go into a seperate line. This makes adding/removing files
much easier, especially when keeping the list in alphabetical order.
Like
## Rules to build libgfx
libadonthell_gfx_la_SOURCES = \
animation.cc \
image.cc \
drawable.cc \
drawing_area.cc \
pnm.cc \
screen.cc \
surface.cc
All that can be seen in the SDL Makefiles, which are written very well,
as far as I can see.
Otherwise, no complaints :).
Kai