autoconf-archive-maintainers | |
[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc.
From: |
Peter Simons |
Subject: |
Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc. |
Date: |
Tue, 28 Jun 2011 13:09:57 +0200 |
Hi Maarten,
> If there were some submission guidelines stating the width of
> description lines and how to properly mark a macro deprecated, I
> could have done that before submitting the patches. The current
> guidelines on the website only seem to cover completely new macro
> submissions.
yes, you are right. Our procedures aren't documented very well. There is
a file "README-maint" in the Git repository that covers some ground, and
we have fairly good automated QA checks that you can run by calling
"make maintainer-all". Still, the situation is a bit of a mess.
>> If at all possible, there should be just one macro per m4 file.
>
> OK, that sounds reasonable. I'm OK with the current situation though,
> but if anyone wants to extract the AX_APPEND_* macros to a new file,
> feel free. Note that the AX_APPEND_{COMPILE,LINK}_FLAGS macros depend
> on both AX_APPEND_FLAG and the respective AX_CHECK_*_FLAG macros.
Can I ask you a favor? Could you please make that change? Splitting
those macros in separate files is not a mechanical procedure, because
the documentation needs to be adapted as well, etc. If would really be
way easier if you could do that, instead of someone else doing it.
> About the snippet you added to NEWS: [...] The macro is not called
> AX_CHECK_FLAG, that is the name of the file that contains
> AX_CHECK_COMPILE_FLAG and others.
Right, my mistake. Thank you for catching that! I've committed a new
entry in 1eb1f849 that should improve the situation.
Take care,
Peter
- Patches for implementing checking for valid CFLAGS, LDFLAGS, etc., Maarten Bosmans, 2011/06/20
- [PATCH 1/7] ax_cflags_*_option.m4: Consolidate _OLD and _NEW macros, Maarten Bosmans, 2011/06/20
- [PATCH 2/7] ax_cflags_*_option.m4: Consolidate CFLAGS and CXXFLAGS macros, Maarten Bosmans, 2011/06/20
- [PATCH 4/7] ax_cflags_*_option.m4: Use AX_CHECK_COMPILE_FLAG macro to do most of the work, Maarten Bosmans, 2011/06/20
- [PATCH 5/7] ax_cflags_*_option.m4: Use AX_APPEND_FLAG macro to append the flag, Maarten Bosmans, 2011/06/20
- [PATCH 3/7] Add ax_check_flag.m4, Maarten Bosmans, 2011/06/20
- [PATCH 7/7] Implement AX_*_CHECK_FLAG on top of ax_check_flag.m4 macros, Maarten Bosmans, 2011/06/20
- [PATCH 6/7] Implement AX_CHECK_*_FLAGS on top of ax_check_flag.m4 macros, Maarten Bosmans, 2011/06/20
- Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc., Peter Simons, 2011/06/25
- Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc., Maarten Bosmans, 2011/06/25
- Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc.,
Peter Simons <=
- Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc., Maarten Bosmans, 2011/06/28
- Re: Patches for implementing checking for valid CFLAGS, LDFLAGS, etc., Peter Simons, 2011/06/30