autoconf-archive-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch #9674] ax_check_enable_debug: Default to "yes", not "no"


From: Debarshi Ray
Subject: [patch #9674] ax_check_enable_debug: Default to "yes", not "no"
Date: Mon, 13 Aug 2018 06:41:12 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0

URL:
  <http://savannah.gnu.org/patch/?9674>

                 Summary: ax_check_enable_debug: Default to "yes", not "no"
                 Project: GNU Autoconf Archive
            Submitted by: debarshiray
            Submitted on: Mon 13 Aug 2018 02:41:10 PM +04
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

The documentation doesn't state what the default value of the first argument
would be, if none is specified. However, reading the code (eg., "empty mean
debug yes") and the commit messages (eg., commit 407ddbbc953737a6) it does
seem that the first argument is meant to default to "yes", whereas in reality
the default is "no".

That is surprising because if someone is using the following snippet, then all
builds, release or non-release, default to "no":
    AX_IS_RELEASE([git-directory])
    AX_CHECK_ENABLE_DEBUG()

Why would anybody want that if they explicitly chose to use the
AX_CHECK_ENABLE_DEBUG?

Therefore, it is better to switch the default to "yes".

There's no need to sanitize the enable_debug variable after AC_ARG_ENABLE.
It's going to be set to the default value if neither --enable-debug nor
--disable-debug are present. If they are present, it's going to be set to
"yes" or "no" respectively, or whatever value was explicitly specified.




    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/patch/?9674>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]