[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


From: Pavel Roskin
Date: Tue, 26 Sep 2000 09:57:12 -0400 (EDT)


When aclang.m4 was changed its revision from 1.36 to 1.37 some lines were
added after the following line:

AC_MSG_ERROR([_AC_LANG compiler cannot create executables], 77)])[]dnl

This line used to precede the end of the macro definition, but this change
put AC_MSG_CHECKING right after that line so that both macros were glued
together. This resulted in the following shell code:

rm -f conftest.$ac_objext conftest$ac_exeext conftest.$ac_extecho \
"configure:1067: checking whether we are cross compiling" >&5

Please notice $ac_extecho

Rationale: one extra newline wouldn't hurt, but one missing newline can. I
really don't like those []dnl's - they are ugly an contribute to errors.

Anyway, let's limit ourselves to minimal fixes since 2.50 is close.

By the way, this bug has been found by chance. I tested autoconf on
Cygwin, and `:' is used on Windows NT to address streams within files.

"rm -f" only reports errors when removing non-existing streams in the
existing files, and yes, by a "configure" did exist at that time :-)

Another rationale: sometimes testing on weird systems help find bugs
affecting all systems, even very common ones :-)

Pavel Roskin

Index: ChangeLog
--- ChangeLog   Mon Sep 25 12:19:02 2000
+++ ChangeLog   Tue Sep 26 09:43:23 2000
@@ -1,3 +1,8 @@
+2000-09-26  Pavel Roskin  <address@hidden>
+       * aclang.m4 (_AC_LANG_COMPILER_WORKS): Remove []dnl because it
+       caused invalid shell code.
 2000-09-25  Alexandre Oliva  <address@hidden>
        * tests/semantics.m4 (AC_PROG_CPP with warning): Simplified.
Index: aclang.m4
--- aclang.m4   Thu Sep 14 08:41:08 2000
+++ aclang.m4   Tue Sep 26 09:43:23 2000
@@ -522,7 +522,7 @@
-AC_MSG_ERROR([_AC_LANG compiler cannot create executables], 77)])[]dnl
+AC_MSG_ERROR([_AC_LANG compiler cannot create executables], 77)])
 AC_MSG_CHECKING([whether we are cross compiling])

reply via email to

[Prev in Thread] Current Thread [Next in Thread]