[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Solaris -R check fails

From: Pavel Roskin
Subject: Re: Solaris -R check fails
Date: Mon, 30 Oct 2000 15:25:01 -0500 (EST)

Hello, Akim!

> | ChangeLog:
> |         * acgeneral.m4 (_AC_LINK_IFELSE): Always create the test source.
> |         Default to AC_LANG_PROGRAM() if the first argument is empty.
> | 
> This is not good.  The convention for AC_..._IFELSE is that if you
> didn't pass a program to compile, you have created it, and you want
> the macros to use it.  Then it's also your responsibility to remove it
> (no longer AC_..._IFELSE's).

Then the authors of AC_PATH_XTRA ignored our convention :-)

My understanding is that the AC_PATH_XTRA just makes sure that the linker
understands the "-R" option, so it's not needed to supply a program really
using the X libraries. AC_LANG_PROGRAM() should be sufficient.

        * acspecific.m4 (AC_PATH_XTRA): Use AC_LANG_PROGRAM() as the
        argument to AC_LINK_IFELSE.

Pavel Roskin

Index: acspecific.m4
--- acspecific.m4       Wed Oct 25 14:17:41 2000
+++ acspecific.m4       Mon Oct 30 11:57:26 2000
@@ -1390,13 +1390,13 @@
     "SunOS 5"*)
       AC_MSG_CHECKING(whether -R must be followed by a space)
       ac_xsave_LIBS=$LIBS; LIBS="$LIBS -R$x_libraries"
-      AC_LINK_IFELSE([], ac_R_nospace=yes, ac_R_nospace=no)
+      AC_LINK_IFELSE([AC_LANG_PROGRAM()], ac_R_nospace=yes, ac_R_nospace=no)
       if test $ac_R_nospace = yes; then
        X_LIBS="$X_LIBS -R$x_libraries"
        LIBS="$ac_xsave_LIBS -R $x_libraries"
-       AC_LINK_IFELSE([], ac_R_space=yes, ac_R_space=no)
+       AC_LINK_IFELSE([AC_LANG_PROGRAM()], ac_R_space=yes, ac_R_space=no)
        if test $ac_R_space = yes; then
          X_LIBS="$X_LIBS -R $x_libraries"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]