autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: autoheader should protect config.h against multiple inclusion


From: Akim Demaille
Subject: Re: autoheader should protect config.h against multiple inclusion
Date: 18 Jan 2001 10:16:56 +0100
User-agent: Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.1 (Crater Lake)

>>>>> "Steven" == Steven G Johnson <address@hidden> writes:

Steven> It occurred to me today that the config.h.in file output by
Steven> autoheader does not have the standard #ifndef CONFIG_H
Steven> ... #endif boilerplate to protect against multiple inclusions.
Steven> Although this is not an issue most of the time for config.h,
Steven> it seems like good practice to do it, so I've attached a patch
Steven> below.  (I can't think of any reason *not* to do it.)

Still, should be debated, as this has been raised several times, and
has never been done.

Some people have said, by the past, that they post process config.h,
and new things would break their treatment.  OTOH, I just don't care,
that's not part of our contract :)

As you say, it's pointless in the case of config.h, so why do you want
to do it?  I'm a bit reluctant, because I don't want people to
transform config.h into some sort of system.h, as it would forbid
future evolutions precisely towards autosystem.  A good config.h can
be reread several times, it should not typedef, prototype etc.

And those who want those guards can still use AH_BOTTOM, and AH_TOP
(not sure of the name, but something like this).

I agree ``I can't think of any reason *not* to do it.'' is a good
argument, but would you have positive arguments?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]