Re: Avoid poor request for a header bug report when using old AC_INIT

[Noah Misch]

On Mon, Apr 03, 2006 at 07:59:24PM +0200, Ralf Wildenhues wrote:
> * Noah Misch wrote on Mon, Apr 03, 2006 at 07:23:54PM CEST:
> > This patch makes `configure' omit the report request when we have no
> > bug report address to provide.  Ok?
> 
> How about this instead?

> --- lib/autoconf/headers.m4   3 Apr 2006 03:18:39 -0000       1.46
> +++ lib/autoconf/headers.m4   3 Apr 2006 17:53:20 -0000
> @@ -137,8 +137,10 @@
>      AC_MSG_WARN([$1: in the future, the compiler will take precedence])
>      (
>        AS_BOX([Report this to ]m4_ifset([AC_PACKAGE_BUGREPORT],
> -                                    [AC_PACKAGE_BUGREPORT],
> -                                    [the AC_PACKAGE_NAME lists. ]))
> +                             [AC_PACKAGE_BUGREPORT],
> +                              m4_ifset([AC_PACKAGE_NAME],
> +                                [the AC_PACKAGE_NAME lists. ],
> +                                [the maintainer of this package. ])))
>      ) |
>        sed "s/^/$as_me: WARNING:     /" >&2

That's fine too; I didn't do it for three reasons:

1. If the `configure.ac' used the two-argument form of AC_INIT, perhaps the
   author does not want bug reports.

2. Not all packages have mailing lists for bug reports.

3. If a `configure.ac' uses an old-style AC_INIT, there's a decent chance that
   it is supposed to work properly with both Autoconf 2.13 and Autoconf 2.5X.
   Autoconf 2.13 does not accept the INCLUDES argument to AC_CHECK_HEADERs, so
   one is less free to add those and fix the warning.

It's not very important; my main goal was to eliminate the exceptionally
unhelpful literal AC_PACKAGE_NAME, which your patch also accomplishes.  If you
prefer it, feel free to install it.