autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Spurious datarootdir warnings in Wine configure


From: Ralf Wildenhues
Subject: Re: Spurious datarootdir warnings in Wine configure
Date: Fri, 23 Jun 2006 01:29:23 +0200
User-agent: Mutt/1.5.11+cvs20060403

Hello Paul, Stepan,

* Paul Eggert wrote on Fri, Jun 23, 2006 at 01:04:33AM CEST:
> Ralf Wildenhues <address@hidden> writes:
> 
> > +To help with the transition, some heuristics have been put in place that
> > +warn about files which seem to lack a definition of @code{datarootdir},
> > +and try to use an initialization not based on the new variable.
> 
> I got a bit confused with that.  How about this rewording?
> 
>   To help with the transition, Autoconf warns about makefiles that seem
>   to use @code{datarootdir} without defining it.

It's good but it does not carry all information: it's important to know
that, with _some_ of the warnings we give, we also change the
substitutions: we expand $datarootdir.  How about this?

 To help with the transition, Autoconf warns about makefiles that seem
 to use @code{datarootdir} without defining it.  In some cases, it then
 expands the value of @code{$datarootdir} in substitutions of the
 directory variables.

> (Or, if the heuristics aren't limited to makefiles, change "makefiles"
> to "files" in the proposed rewording.)

Yes, that should be "files".

I've incorporated all other changes suggested by Stepan and you in my
copy.  Thanks for the reviews!

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]