Re: fix AT_SETUP's sh-escaping

[Joel E. Denny]

On Wed, 8 Nov 2006, Ralf Wildenhues wrote:

> AFAICS this patch introduces nonportable sed scripts which cause tests
> 64 65 66 67 68 69 70 71 72 74 to fail on FreeBSD 6.1 (for a different
> reason than they may have failed before :-).
> 
> OK to apply?  There's no need to avoid '\{1,\}' for portability, right?

For what it's worth, these changes work for me, but I know little about 
portability.

> Furthermore, test 76 (Macro with backslash) gets an UNEXPECTED PASS on
> several systems (HP-UX, IRIX, OpenBSD, Solaris).  Not analyzed yet.

I just tried this under Solaris with your patch, and I get the expected 
failure.  In case it helps, the verbose failure contains:

./autotest.at:294: ./micro-suite | sed -n "s/[^:]*: \(.*[^       ]\)[    
]*ok.*/\1/p"
--- -   2006-11-08 20:25:35.000000000 -0500
+++ /home/jdenny/cs/current/autoconf/sources/tests/testsuite.dir/at-stdout     
2006-11-08 20:25:35.000000000 -0500
@@ -1,2 +1,2 @@
-A \\ in my name
+A \ in my name

However, I get FAILED for 67 (Backslash in a test title).  Here's an 
update to your patch that fixes it:

Index: ChangeLog
===================================================================
RCS file: /sources/autoconf/autoconf/ChangeLog,v
retrieving revision 1.3089
diff -p -u -r1.3089 ChangeLog
--- ChangeLog   8 Nov 2006 21:44:32 -0000       1.3089
+++ ChangeLog   9 Nov 2006 03:14:04 -0000
@@ -1,3 +1,9 @@
+2006-11-08  Ralf Wildenhues  <address@hidden>
+       and Joel E. Denny  <address@hidden>
+
+        * tests/autotest.at (AT_CHECK_AT_TITLE): Fix non-portable sed
+        scripts, and use $CONFIG_SHELL when invoking ./micro-suite.
+
 2006-11-08  Paul Eggert  <address@hidden>
 
        * lib/autoconf/types.m4 (AC_TYPE_LONG_LONG_INT): Set
Index: tests/autotest.at
===================================================================
RCS file: /sources/autoconf/autoconf/tests/autotest.at,v
retrieving revision 1.18
diff -p -u -r1.18 autotest.at
--- tests/autotest.at   27 Oct 2006 23:05:34 -0000      1.18
+++ tests/autotest.at   9 Nov 2006 03:14:04 -0000
@@ -257,11 +257,11 @@ AT_SETUP([$2])
 AT_CHECK([:])
 AT_CLEANUP
 ]], [$4], [], [], [],
-[AT_CHECK([[./micro-suite | sed -n "s/[^:]*: \(.*[^ \t]\)[ \t]*ok.*/\1/p"]],,
+[AT_CHECK([[$CONFIG_SHELL ./micro-suite | sed -n "s/[^:]*: \(.*[^       ]\)[   
 ]*ok.*/\1/p"]],,
 [[$3
 ]])
-AT_CHECK([[./micro-suite -l \
-             | sed -n "s/.*[0-9]\+: [^ \t]\+[ \t]\+\(.*[^ \t]\)[ \t]*/\1/p"]],,
+AT_CHECK([[$CONFIG_SHELL ./micro-suite -l \
+             | sed -n "s/.*[0-9]\{1,\}: [^      ]\{1,\}[        ]\{1,\}\(.*[^  
 ]\)[    ]*/\1/p"]],,
 [[$3
 ]])
 AT_CHECK([[sed -n "s/[^.]*\. \(.*\) ([^)]*): ok.*/\1/p" micro-suite.log]],,