autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: AT_TESTED issues


From: Ralf Wildenhues
Subject: Re: AT_TESTED issues
Date: Sun, 21 Oct 2007 14:09:06 +0200
User-agent: Mutt/1.5.16 (2007-10-11)

Hello Eric,

Please note that the patch you posted was newline-mangled, which makes
reviewing harder, as does mixing reformatting changes with nontrivial
ones.

* Eric Blake-1 wrote on Thu, Oct 18, 2007 at 06:15:03PM CEST:
> 2007-10-18  Eric Blake  <address@hidden>
> 
>       Fix AT_TESTED, AT_KEYWORDS.
>       * lib/m4sugar/m4sugar.m4 (m4_append_uniq): Warn if separator
>       occurs in string, as duplicates may be added.
>       (_m4_append_uniq): New helper macro.
>       (m4_append_uniq_w): New macro.
>       * lib/autotest/general.m4 (AT_TESTED, AT_KEYWORDS): Fix
>       duplication bug by using new macro.
>       (AT_INIT) <at_tested>: Restore newline separators.  Invoke tested
>       programs with stdin redirected, so programs that don't
>       understand --version won't try to behave interactively.
>       * tests/autotest.at (Tested programs): Catch this bug.

The change to the `Keywords and ranges' test not listed in the ChangeLog
entry.

>       * tests/m4sugar.at (m4@&address@hidden): Test new macro.

>       * tests/local.at (AT_TESTED): Add m4, perl.

If you do this, this fails:

  ./configure PERL=/some/where/not/in/PATH/perl

Likewise for m4.  I've been using it on some systems.  If there is
another perl in the PATH, then the wrong data will be recorded.

Cheers,
Ralf

>       * doc/autoconf.texi (Text processing Macros): Document
>       m4_append_uniq_w, and update text on m4_append.
>       * NEWS: Document the addition.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]