autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] builds: quote `like this', not 'like this'


From: Stefano Lattarini
Subject: Re: [PATCH] builds: quote `like this', not 'like this'
Date: Fri, 21 Sep 2012 12:56:38 +0200

Hmpf, same stupid mistake in the 'Subject:' line.

I've fixed it, and also fixed the other unrelated typo 's/builds/build/'.

While at it, also converted the only occurrence of `this quoting' in the
'.m4' files used by autoconf's own configury.  The updated patch is below.

Sorry for the noise,
  Stefano

-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----8<-----

>From b5405cae0fd42829d5ba3b520423b48acc4747db Mon Sep 17 00:00:00 2001
Message-Id: <address@hidden>
From: Stefano Lattarini <address@hidden>
Date: Fri, 21 Sep 2012 12:34:48 +0200
Subject: [PATCH] build: quote 'like this', not `like this'

As per updated GCS recommendations.

* Makefile.am, configure.ac, lib/m4sugar/Makefile.am,
tests/Makefile.am, m4/m4.m4: Here.

Signed-off-by: Stefano Lattarini <address@hidden>
---
 Makefile.am             | 6 +++---
 configure.ac            | 8 ++++----
 lib/m4sugar/Makefile.am | 2 +-
 m4/m4.m4                | 2 +-
 tests/Makefile.am       | 8 ++++----
 5 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/Makefile.am b/Makefile.am
index bed0b6c..c0eecbf 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -16,7 +16,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.

 # bin/ must be run first, as it builds executables needed for tests.
-# autom4te uses autotest.m4f to generate `testsuite', so build tests last.
+# autom4te uses autotest.m4f to generate 'testsuite', so build tests last.
 # Rules in man/ use scripts from both bin/ and tests/, so *it* goes last.
 SUBDIRS = bin . lib doc tests man

@@ -114,8 +114,8 @@ check-coverage-run: all

 check-coverage-report:
        @if test ! -d $(PERL_COVERAGE_DB); then \
-         echo "No coverage database found in \`$(PERL_COVERAGE_DB)'." >&2; \
-         echo "Please run \`make check-coverage' first" >&2; \
+         echo "No coverage database found in '$(PERL_COVERAGE_DB)'." >&2; \
+         echo "Please run 'make check-coverage' first" >&2; \
          exit 1; \
        fi
        $(PERL_COVER) $(PERL_COVERAGE_DB) $(PERL_COVER_FLAGS)
diff --git a/configure.ac b/configure.ac
index 696e513..2d83177 100644
--- a/configure.ac
+++ b/configure.ac
@@ -30,9 +30,9 @@ AM_INIT_AUTOMAKE([1.11 dist-xz readme-alpha no-texinfo.tex 
std-options])

 AB_INIT

-# We use `/bin/sh -n script' to check that there are no syntax errors
+# We use '/bin/sh -n script' to check that there are no syntax errors
 # in the scripts.  Although incredible, there are /bin/sh that go into
-# endless loops with `-n', e.g., SunOS's:
+# endless loops with '-n', e.g., SunOS's:
 #
 #   $ uname -a
 #   SunOS ondine 4.1.3 2 sun4m unknown
@@ -50,8 +50,8 @@ AB_INIT
 # Also, some implementations of /bin/sh (e.g., Solaris 8) are soooo slow
 # that they are unusable on large scripts like our testsuite.

-# So before using `/bin/sh -n' to check our scripts, we first check
-# that `/bin/sh -n' is known to not have these problems.
+# So before using '/bin/sh -n' to check our scripts, we first check
+# that '/bin/sh -n' is known to not have these problems.

 AC_CACHE_CHECK([whether /bin/sh -n is known to work], [ac_cv_sh_n_works],
 [if (
diff --git a/lib/m4sugar/Makefile.am b/lib/m4sugar/Makefile.am
index 23824a3..26d20db 100644
--- a/lib/m4sugar/Makefile.am
+++ b/lib/m4sugar/Makefile.am
@@ -28,7 +28,7 @@ RELEASE_YEAR = \
 ## version.m4.  ##
 ## ------------ ##

-# The `:;' works around a redirected compound command bash exit status bug.
+# The ':;' works around a redirected compound command bash exit status bug.
 version.m4: Makefile
        :;{ \
          echo '# This file is part of -*- Autoconf -*-.' && \
diff --git a/m4/m4.m4 b/m4/m4.m4
index a19af67..7657458 100644
--- a/m4/m4.m4
+++ b/m4/m4.m4
@@ -18,7 +18,7 @@
 # Also avoid versions of m4 that trigger strstr bugs.
 AC_DEFUN([AC_PROG_GNU_M4],
   [AC_ARG_VAR([M4], [Location of GNU M4 1.4.6 or later.  Defaults to the first
-    program of `m4', `gm4', or `gnum4' on PATH that meets Autoconf needs.])
+    program of 'm4', 'gm4', or 'gnum4' on PATH that meets Autoconf needs.])
   AC_CACHE_CHECK([for GNU M4 that supports accurate traces], [ac_cv_path_M4],
     [rm -f conftest.m4f
 ac_had_posixly_correct=${POSIXLY_CORRECT:+yes}
diff --git a/tests/Makefile.am b/tests/Makefile.am
index c946773..9e5a6b8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -22,7 +22,7 @@
 EXTRA_DIST = $(TESTSUITE_AT) local.at mktests.sh \
             atlocal.in wrapper.as statesave.m4

-# Running the uninstalled scripts.  Build them upon `all', for the manpages.
+# Running the uninstalled scripts.  Build them upon 'all', for the manpages.
 noinst_SCRIPTS = $(wrappers)
 DISTCLEANFILES = atconfig atlocal $(TESTSUITE)
 MAINTAINERCLEANFILES = Makefile.in
@@ -35,7 +35,7 @@ include ../lib/freeze.mk
 ## package.m4.  ##
 ## ------------ ##

-# The `:;' works around a redirected compound command bash exit status bug.
+# The ':;' works around a redirected compound command bash exit status bug.
 package.m4: Makefile
        :;{ \
          echo '# Signature of the current package.' && \
@@ -109,7 +109,7 @@ TESTSUITE_AT = $(TESTSUITE_GENERATED_AT) 
$(TESTSUITE_HAND_AT)
 TESTSUITE = ./testsuite

 # Run the non installed autom4te.
-# Don't use AUTOM4TE since `make alpha' makes it unavailable although
+# Don't use AUTOM4TE since 'make alpha' makes it unavailable although
 # we are allowed to use it (since we ship it).
 AUTOTEST = $(MY_AUTOM4TE) --language=autotest
 $(TESTSUITE): package.m4 \
@@ -158,7 +158,7 @@ MAINTAINERCLEANFILES += $(TESTSUITE_GENERATED_AT)

 # The files which contain macros we check for syntax.  Use $(top_srcdir)
 # for the benefit of non-GNU make.  Fix the names in the rule below
-# where we `cd' to $srcdir.
+# where we 'cd' to $srcdir.
 autoconfdir = $(top_srcdir)/lib/autoconf
 AUTOCONF_FILES = $(autoconfdir)/general.m4 \
                 $(autoconfdir)/status.m4 \
-- 
1.7.12.317.g1c54b74



reply via email to

[Prev in Thread] Current Thread [Next in Thread]