Re: mdate-sh

[Paul Eggert]

> Date: Mon, 23 Dec 2002 14:23:08 +0100
> From: Andreas Buening <address@hidden>

> +# Get the extended ls output of the root directory.
> +set - x`eval $ls_command /`

The "eval " shouldn't be needed here, so it's better to remove it.


> +# Get the extended ls output of the file or directory.
> +set - x`eval $ls_command "\"$save_arg1\""`

Better would be

set - x`eval "$ls_command \"\$save_arg1\""`

as this will handle arguments that contain metacharacters like space
or '"'.

Also, when you resubmit the patch, can you please submit a proper
ChangeLog entry?  See the ChangeLog file for examples.  Thanks.