Re: documentation through doxygen stopped working

[Russ Allbery]

Russ Allbery <address@hidden> writes:
> Ralf Wildenhues <address@hidden> writes:

>> That smells of M4 overquoting somewhere.  Find out what changed, the
>> Autoconf version, or any third-party macro code, or configure.ac.  In
>> case of doubt, please post a small example to reproduce the above
>> together with a pointer to the exact DX_REQUIRE_PROG macro
>> implementation.

> I just ran into the same thing when going from Autoconf 2.61 to 2.63.

The following patch appears to fix the problem, although I'm not very
comfortable with it.  This business of forming variable names by
concatenating a macro expansion with a static string makes me nervous
because I don't understand the quoting implications.  I'm worried that
this is just going to break again.  I'd love to see this class reworked to
use a more obvious and clear approach to this.

--- a/doxygen.m4
+++ b/doxygen.m4
@@ -76,9 +76,9 @@ AC_DEFUN([DX_IF_FEATURE], [ifelse(DX_FEATURE_$1, ON, [$2], 
[$3])])
 # Require the specified program to be found for the DX_CURRENT_FEATURE to work.
 AC_DEFUN([DX_REQUIRE_PROG], [
 AC_PATH_TOOL([$1], [$2])
-if test "$DX_FLAG_[]DX_CURRENT_FEATURE$$1" = 1; then
+if test "$[DX_FLAG_]DX_CURRENT_FEATURE$$1" = 1; then
     AC_MSG_WARN([$2 not found - will not DX_CURRENT_DESCRIPTION])
-    AC_SUBST([DX_FLAG_[]DX_CURRENT_FEATURE], 0)
+    AC_SUBST([DX_FLAG_]DX_CURRENT_FEATURE, 0)
 fi
 ])
 
@@ -101,7 +101,7 @@ test "$DX_FLAG_$1" = "$2" \
 # ----------------------------------------------------------
 # Turn off the DX_CURRENT_FEATURE if the required feature is off.
 AC_DEFUN([DX_CLEAR_DEPEND], [
-test "$DX_FLAG_$1" = "$2" || AC_SUBST([DX_FLAG_[]DX_CURRENT_FEATURE], 0)
+test "$DX_FLAG_$1" = "$2" || AC_SUBST([DX_FLAG_]DX_CURRENT_FEATURE, 0)
 ])
 
 # DX_FEATURE_ARG(FEATURE, DESCRIPTION,

-- 
Russ Allbery (address@hidden)             <http://www.eyrie.org/~eagle/>