Re: Can you spot the error?

[Philipp Thomas]

* Eric Blake (address@hidden) [20140403 14:07]:

> Did you also fix the quoting in the other AC_ARG_WITH:

Here is the part in question, AFAICT I did fix the quoting:

dnl Process this file with autoconf to produce a configure script.

AC_ARG_WITH([valgrind],
    [AS_HELP_STRING([--with-valgrind],
        [Enable Valgrind annotations (small runtime overhead, default NO)])])
if test x$with_valgrind = x || test x$with_valgrind = xno; then
    want_valgrind=no
    AC_DEFINE([NVALGRIND], 1, [Define to 1 to disable Valgrind annotations.])
else
    want_valgrind=yes
    if test -d $with_valgrind; then
        CPPFLAGS="$CPPFLAGS -I$with_valgrind/include"
    fi
fi

AC_ARG_WITH([resolve-neigh],
    [AS_HELP_STRING([--with-resolve-neigh],
        [Enable neighbour resolution in Ethernet (default YES)])])
have_libnl=no
if  test x$with_resolve_neigh = x || test x$with_resolve_neigh = xyes; then
        PKG_CHECK_MODULES([LIBNL],[libnl-3.0],
                          [have_libnl=yes
                           AC_DEFINE([HAVE_LIBNL3], [1], [Use libnl-3.0])
                           AC_DEFINE([HAVE_LIBNL], [1],  [Use libnl])
                           PKG_CHECK_MODULES([LIBNL_ROUTE3], [libnl-route-3.0])
                           LIBNL_CFLAGS="$LIBNL_CFLAGS $LIBNL_ROUTE3_CFLAGS"
                           LIBNL_LIBS="$LIBNL_LIBS $LIBNL_ROUTE3_LIBS"], [:]
                          )
        if test "$have_libnl" = no; then
                PKG_CHECK_MODULES([LIBNL], [libnl-1], [have_libnl=yes
                                  AC_DEFINE([HAVE_LIBNL1], [1], [Use libnl-1])
                                  AC_DEFINE([HAVE_LIBNL], [1],  [Use libnl])
                                  AC_CHECK_LIB(nl, rtnl_link_vlan_get_id, [],
                                        AC_MSG_ERROR([rtnl_link_vlan_get_id not 
found.  libibverbs requires libnl.]))
                                 ],[
                                        AC_MSG_ERROR([libibverbs requires 
libnl.])
                                 ])
        fi
else
    AC_DEFINE([NRESOLVE_NEIGH], 1, [Define to 1 to disable resovle neigh 
annotations.])
fi