automake-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[automake-commit] 01/02: maint: avoid a racy distcheck failure


From: Jim Meyering
Subject: [automake-commit] 01/02: maint: avoid a racy distcheck failure
Date: Wed, 27 Dec 2023 11:59:20 -0500

meyering pushed a commit to branch master
in repository automake.

View the commit online:
https://git.savannah.gnu.org/gitweb/?p=automake.git;a=commitdiff;h=c8fcdede16b034260d779ff3f064b84d55064000

commit c8fcdede16b034260d779ff3f064b84d55064000
Author: Jim Meyering <meyering@meta.com>
AuthorDate: Wed Dec 27 06:52:50 2023 -0800

    maint: avoid a racy distcheck failure
    
    * lib/am/distdir.am (am__remove_distdir): Use ";" not "&&" after
    the chmod-running find, so that a failing find doesn't cause the
    entire rule to fail.  This could happen when a directory like
    doc/automake.t2d being processed by find is concurrently deleted
    by another rule.
---
 lib/am/distdir.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/am/distdir.am b/lib/am/distdir.am
index 301239de1..0dd3a2e3f 100644
--- a/lib/am/distdir.am
+++ b/lib/am/distdir.am
@@ -24,7 +24,7 @@ top_distdir = $(distdir)
 am__remove_distdir = \
   if test -d "$(distdir)"; then \
     find "$(distdir)" -type d ! -perm -700 -exec chmod u+rwx {} ';' \
-      && rm -rf "$(distdir)" \
+      ; rm -rf "$(distdir)" \
 ## On MSYS (1.0.17) it is not possible to remove a directory that is in
 ## use; so, if the first rm fails, we sleep some seconds and retry, to
 ## give pending processes some time to exit and "release" the directory



reply via email to

[Prev in Thread] Current Thread [Next in Thread]