Re: [Automake-NG] [PATCH 15/17] [ng] check: warn about dot-less $(TEST_EXTENSIONS) at make runtime

[Akim Demaille]

Le 23 mai 2012 à 00:34, Stefano Lattarini a écrit :

> * lib/am/parallel-tests.am: Analyze the $(TEST_EXTENSIONS) contents at
> make runtime, instead of relying on the '%INVALID_TEST_EXTENSIONS%'
> transform once passed in by automake.  Do any necessary error reporting
> with the help of ...
> (am__maybe_invalid_test_extensions): ... this new function.
> * automake.in (is_valid_test_extension): Delete.
> (handle_tests): Don't call that anymore.  Simplify accordingly.  Rely
> on code in parallel-tests.am to report the proper errors at runtime.
> * t/test-extensions.sh: Moved ...
> * t/test-extensions-invalid.sh:  ... to this, nd updated.
> * Makefile.am (XFAIL_TESTS): Drop 'test-extensions.sh'.
> 
> Signed-off-by: Stefano Lattarini <address@hidden>
> ---
> 
> Here is the patch to be substituted to the old one "[ng] check: accept
> dot-less entries in $(TEST_EXTENSIONS)".
> 
> OK?

Fine!

> - INVALID_TEST_EXTENSIONS => "@invalid_test_suffixes");

This is an example of what I'd like to see removed
from Automake: redundant vocabulary.  Chose between
"suffix" and "extension", and stick to it.  Of course
I am more troubled when this arises in the API than
in automake's code, yet squashing this everywhere would
be nice imho.