automake-ng
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Automake-NG] [PATCH 00/15] Simplify and refacotor variable handling a b


From: Stefano Lattarini
Subject: [Automake-NG] [PATCH 00/15] Simplify and refacotor variable handling a bit
Date: Fri, 25 May 2012 13:38:22 +0200

Far from the sweeping simplifications I was hoping for when I started
writing this series, but they are good to go IMHO.  A better cleanup
(which I still hope I'll be able to do eventually) will probably require
a rewrite of the Automake::Variable and Automake::VarDef modules :-/

OK for ng/master?  I will push in a couple of days if there is no
objection.

Regards,
  Stefano

-*-*-

Stefano Lattarini (15):
  [ng] cleanup: remove unused private variables in Automake::Variable
  [ng] vars: get rid of VAR_SORTED type
  [ng] vars: get rid of VAR_SILENT type
  [ng] tests: spy behaviour of '+=' with GNU make
  [ng] tests: Automake should let us append to undefined variables (someday)
  [ng] refactor: support comments only for VarDef, not for ItemDef too
  [ng] VarDef: store comments and values as a perl array
  [ng] vars: simplify logic for appending conditionally
  [ng] vars: keep track of conditionals in appended values and comments
  [ng] vars: get rid of VAR_ASIS / VAR_PRETTY distinction
  [ng] refactor: change signature of 'define_variable()'
  [ng] cleanup: prefer 'define_variable' over 'define_pretty_variable'
  [ng] rename: define_pretty_variable -> define_cond_variable()
  [ng] cosmetics: avoid redundant use of '&' in subroutine calls
  [ng] vars: remove some safety checks in Automake::Variable::define

 Makefile.am                       |    2 +
 automake.in                       |  196 +++++++++++++++----------------------
 lib/Automake/ItemDef.pm           |   17 +---
 lib/Automake/Rule.pm              |    4 +-
 lib/Automake/RuleDef.pm           |   13 ++-
 lib/Automake/VarDef.pm            |   98 +++++++------------
 lib/Automake/Variable.pm          |  181 ++++++++++------------------------
 t/check2.sh                       |    3 +-
 t/cond38.sh                       |    3 -
 t/distcom-subdir.sh               |   28 ++++--
 t/distcom2.sh                     |   19 +---
 t/longline.sh                     |   19 ++--
 t/pluseq3.sh                      |    2 +-
 t/spy-var-append.sh               |   57 +++++++++++
 t/subdir4.sh                      |    9 +-
 t/subst-no-trailing-empty-line.sh |   97 ------------------
 t/var-undef-append.sh             |  100 +++++++++++++++++++
 17 files changed, 374 insertions(+), 474 deletions(-)
 create mode 100755 t/spy-var-append.sh
 delete mode 100755 t/subst-no-trailing-empty-line.sh
 create mode 100755 t/var-undef-append.sh

-- 
1.7.9.5




reply via email to

[Prev in Thread] Current Thread [Next in Thread]