[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Automake-NG] [PATCH] [ng] suffix: don't reject old-fashioned suffix
Re: [Automake-NG] [PATCH] [ng] suffix: don't reject old-fashioned suffix rules anymore
Tue, 29 May 2012 19:47:42 +0200
On 05/29/2012 02:24 PM, Stefano Lattarini wrote:
> Now that, after today's commit 'v1.12-331-g645bb21', Automake-NG does
> not follow the chain of user-defined pattern rules anymore, there's no
> need to treat such rules preferentially, nor to reject old-fashioned
> suffix rules. This will help interoperability with tools like Gnulib,
> which generated Makefile.am fragments that still uses old-fashioned
> suffix rules (since they are targeted to mainline Automake).
> * automake.in (handle_footer): Do not reject the '.SUFFIXES:' rule
> nor the 'SUFFIXES' variable. Add a "FIXME" comment about why we
> still support the 'SUFFIXES' variable.
> * lib/Automake/Rule.pm: Do not error out if an old-fashioned suffix
> rule is seen.
> * lib/am/footer.am (.SUFFIXES): Depend on '$(SUFFIXES)', if that's
> * t/suffix-rules-reject.sh: Remove.
> * t/suffix-rules-old-fashioned.sh: New.
> * NG-NEWS: Adjust.
> Signed-off-by: Stefano Lattarini <address@hidden>
> So we've broken compatibility with mainline automake in one aspect,
> but can recover it in another one. OK for 'ng/master'? I will push
> shortly if there is no objection.