automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: rb3: conditional tests - updated patch


From: Raja R Harinath
Subject: Re: rb3: conditional tests - updated patch
Date: Sun, 05 Aug 2001 19:29:50 -0500
User-agent: Gnus/5.090004 (Oort Gnus v0.04) Emacs/21.0.103

Tom Tromey <address@hidden> writes:
>>>>>> "hari" == Raja R Harinath <address@hidden> writes:
> 
>Hari> Why not use '$MAKE -s'.  GNU make doesn't print the
>Hari> "entering/leaving" messages with that.
> 
> When I change, say, cond16.test to use -s instead, it starts failing.
> I guess the `w' in MAKEFLAGS (I assume that is where it comes from)
> overrides the `-s'.

Aha.  That makes sense.  As far as GNU make is concerned, the 'make'
invocation inside the test script is a sub-make.

Maybe '$srcdir/defs' should 

      unsetenv MAKEFLAGS
 
> In m4/make.m4 we use the `fgrep -v'.  I guess this is ok since
> configure disables NLS.

Yep.  Maybe m4/make.m4 should use

      MAKEFLAGS= $am_make -s -f confmf

instead.  I know, it's not worth the bother.  But, it seems somewhat
cleaner.  We are just ensuring a non-"sub-make" invocation.

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden
"When all else fails, read the instructions."      -- Cahn's Axiom
"Our policy is, when in doubt, do the right thing."   -- Roy L Ash



reply via email to

[Prev in Thread] Current Thread [Next in Thread]