[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: rb5: remove combinatorial explosion patch
From: |
Tom Tromey |
Subject: |
Re: rb5: remove combinatorial explosion patch |
Date: |
11 Aug 2001 21:09:38 -0600 |
>>>>> "Richard" == Richard Boulton <address@hidden> writes:
Richard> The patch removes the combinatorial explosion (in terms of
Richard> memory footprint and Makefile.in size) which currently exists
Richard> when a _SOURCES variable is defined in terms of several
Richard> conditionally defined variables. It does this by defining
Richard> the _OBJECTS variable in terms of a parallel set of
Richard> conditional variables.
This is great stuff.
Richard> I'm not sure whether the name "am_OBJECTS_*" is a good one.
Richard> Its easy to change if people can see a problem with it or
Richard> think of a better one.
The current convention is `am__' as the prefix for internal variables,
and `am--' as the prefix for internal targets.
Richard> However, it passes all the tests, including a few regression
Richard> tests I added specially
I'm sure you know this, but the test suite isn't always a very good
test. There are plenty of things it doesn't catch :-(
Anyway, I think with a few changes (the above, plus the name changes
mentioned in the other email) this should go in on the trunk.
Tom