Re: Patch for a bug in distdir

[Alexandre Duret-Lutz]

>>> "dpovey" == dpovey  <address@hidden> writes:

[...]

 dpovey> If you include a directory in EXTRA_DIST that is in the
 dpovey> build dir, it does not get included in the
 dpovey> distribution.

[...]

 dpovey> The problem is trivially fixed.  I tracked it down to a
 dpovey> test -f being done on DISTFILES in the distdir rule
 dpovey> rather than test -f || test -d.  The following patch
 dpovey> seems to fix the problem.

Does someone object to this change?  It has been requested by a
few other people too.

I think there is still an issue if the subdir also exists in the
source tree and contains some source files meant to be
distributed along with the generated files.  With the above
patch you will distribute only the $builddir copy of the
subdirectory, i.e. distribute the generated files but miss all
sources files.

I don't know how important this is, I'm playing the devil's
advocate here.  Maybe both directories should be merged.
-- 
Alexandre Duret-Lutz