FYI: disable -Wportability (Was: Re: Last part of PR/347: warn about $(foo bar).)

[Alexandre Duret-Lutz]

>>> "Ralf" == Ralf Corsepius <address@hidden> writes:

[...]

 Ralf> IMO, -Wno-portability should be the default (at least for
 Ralf> 1.7), because this is closer to the current behavior and
 Ralf> people would feel pee'd if their long term Makefile.am
 Ralf> suddenly stop working. Making it the default for 1.8
 Ralf> might be worth it, but I am not sure. May-be having a
 Ralf> --pedanic mode instead would be better.

I'm checking this in for now.  (The $(foo bar) patch needs more work: it
should scan the rules for such variable too.)

2002-08-22  Alexandre Duret-Lutz  <address@hidden>

        * automake.in (set_strictness): Never enable 'portability'
        warnings for now.
        (usage): Adjust `-Wportability' doc.
        * automake.texi (Invoking Automake): Likewise.
        Suggested by Ralf Corsepius.

Index: automake.in
===================================================================
RCS file: /cvs/automake/automake/automake.in,v
retrieving revision 1.1338
diff -u -r1.1338 automake.in
--- automake.in 19 Aug 2002 22:48:38 -0000      1.1338
+++ automake.in 22 Aug 2002 17:15:27 -0000
@@ -8608,13 +8608,30 @@
 sub set_strictness
 {
   $strictness_name = $_[0];
+
+  # FIXME: 'portability' warnings are currently disabled by default.
+  # Eventually we want to turn them on in GNU and GNITS modes, but
+  # we don't do this yet in Automake 1.7 to help the 1.6/1.7 transition.
+  #
+  # Indeed there would be only two ways to get rid of these new warnings:
+  #  1. adjusting Makefile.am
+  #     This is not always easy (or wanted).  Consider %-rules or
+  #     $(function args) variables.
+  #  2. using -Wno-portability
+  #     This means there is no way to have the same Makefile.am
+  #     working both with Automake 1.6 and 1.7 (since 1.6 does not
+  #     understand -Wno-portability).
+  #
+  # In Automake 1.8 (or whatever it is called) we can turn these
+  # warnings on, since -Wno-portability will not be an issue for
+  # the 1.7/1.8 transition.
   if ($strictness_name eq 'gnu')
     {
       $strictness = GNU;
       setup_channel 'error-gnu', silent => 0;
       setup_channel 'error-gnu/warn', silent => 0, type => 'error';
       setup_channel 'error-gnits', silent => 1;
-      setup_channel 'portability', silent => 0;
+      # setup_channel 'portability', silent => 0;
       setup_channel 'gnu', silent => 0;
     }
   elsif ($strictness_name eq 'gnits')
@@ -8623,7 +8640,7 @@
       setup_channel 'error-gnu', silent => 0;
       setup_channel 'error-gnu/warn', silent => 0, type => 'error';
       setup_channel 'error-gnits', silent => 0;
-      setup_channel 'portability', silent => 0;
+      # setup_channel 'portability', silent => 0;
       setup_channel 'gnu', silent => 0;
     }
   elsif ($strictness_name eq 'foreign')
@@ -8632,7 +8649,7 @@
       setup_channel 'error-gnu', silent => 1;
       setup_channel 'error-gnu/warn', silent => 0, type => 'warning';
       setup_channel 'error-gnits', silent => 1;
-      setup_channel 'portability', silent => 1;
+      # setup_channel 'portability', silent => 1;
       setup_channel 'gnu', silent => 1;
     }
   else
@@ -8740,7 +8757,7 @@
   `obsolete'      obsolete features or constructions
   `unsupported'   unsupported or incomplete features (default)
   `unused'        unused variables (default)
-  `portability'   portability issues (default in gnu and gnits modes)
+  `portability'   portability issues
   `all'           all the warnings
   `no-CATEGORY'   turn off warnings in CATEGORY
   `none'          turn off all the warnings
Index: automake.texi
===================================================================
RCS file: /cvs/automake/automake/automake.texi,v
retrieving revision 1.296
diff -u -r1.296 automake.texi
--- automake.texi       21 Aug 2002 11:20:10 -0000      1.296
+++ automake.texi       22 Aug 2002 17:15:47 -0000
@@ -1047,7 +1047,7 @@
 @item unused
 unused variables
 @item portability
-portability issues
+portability issues (e.g., use of Make features which are known not portable)
 @item all
 all the warnings
 @item none
@@ -1061,8 +1061,12 @@
 variables.
 
 The categories output by default are @samp{unsupported} and
address@hidden  Additionally, @samp{gnu} and @samp{portability} warnings
-are enabled in @samp{--gnu} and @samp{--gnits} strictness.
address@hidden  Additionally, @samp{gnu} is enabled in @samp{--gnu} and
address@hidden strictness.
+
address@hidden warnings are currently disabled by default, but they
+will be enabled in @samp{--gnu} and @samp{--gnits} strictness in a
+future release.
 
 @vindex WARNINGS
 The environment variable @samp{WARNINGS} can contain a comma separated

-- 
Alexandre Duret-Lutz