Re: Automake::Conditional::invert

[Alexandre Duret-Lutz]

>>> "Raja" == Raja R Harinath <address@hidden> writes:

 Raja> Alexandre Duret-Lutz <address@hidden> writes:
 >> Index: automake.in
 >> ## ------------------------------ ##
 >> ## Handling the condition stack.  ##
 >> ## ------------------------------ ##
 >> @@ -5957,7 +5942,7 @@
 >> 
 >> $cond = "${cond}_TRUE"
 >> unless $cond =~ /^TRUE|FALSE$/;
 >> -  $cond = condition_negate ($cond)
 >> +  $cond = Automake::Conditional::condition_negate ($cond)
 >> if $negate;

 Raja> This pattern should probably be converted to a function
 Raja> make_conditional_string ($cond, $negate);
 Raja> Or even 'make_conditional' and change @cond_stack to store real
 Raja> A::Conditional object references.

Or even... let's move all this into a ConditionalStack class.

[...]

 >> +  # Invert a Conditional.  This returns a ConditionalSet.
 >> +  $set = $both->not;

 Raja> It doesn't :-)

[...]

 >> +Multiply to conditional sets.

 Raja> s/to/two/

I do this mistake two often :)

I'll will fix these too comments in the next patch.  Thanks.

[...]

 Raja> Can we kill $self->permutations then :-)

It is still called from &variable_conditions_recursive and
&variable_conditions_recursive_sub, although I'm not sure if
it's legitimate.

[...]
-- 
Alexandre Duret-Lutz