automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: lex tests pass and fail even though lex/flex is not installed


From: Alexandre Duret-Lutz
Subject: Re: lex tests pass and fail even though lex/flex is not installed
Date: Wed, 26 Feb 2003 13:16:25 +0100
User-agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-pc-linux-gnu)

>>> "Leo" == Leo Davis <address@hidden> writes:

 Leo> versions: automake (GNU automake) 1.7.2
 Leo> autoconf (GNU Autoconf) 2.57

 Leo> When I did `make check' I had the following results with
 Leo> the lex test scripts:

 Leo> PASS: lex.test
 Leo> PASS: lex2.test
 Leo> FAIL: lex3.test
 Leo> PASS: lex4.test
 Leo> FAIL: lex5.test

 Leo> So after checking into why lex3.test failed I noticed the
 Leo> following tests discovered by `configure'

 Leo> checking for flex... no
 Leo> checking for lex... no

 Leo> It turns out that lex.yy.c and foo.c get created when make
 Leo> is run (by `missing'), so the test carries on to its
 Leo> inevitable failure.  I guess I was expecting the tests to
 Leo> be neither PASS nor FAIL, but SKIP (after all it did
 Leo> correctly detect that these programs aren't there).

Thank you for the bug report.  Sorry it took two months to answer :(

I'm installing the following patch on HEAD and branch-1-7.

2003-02-26  Alexandre Duret-Lutz  <address@hidden>

        * tests/lex3.test, tests/lex5.test: Require flex.
        Reported by Leo Davis.

Index: THANKS
===================================================================
RCS file: /cvs/automake/automake/THANKS,v
retrieving revision 1.186.2.21
diff -u -r1.186.2.21 THANKS
--- THANKS      17 Feb 2003 14:55:22 -0000      1.186.2.21
+++ THANKS      26 Feb 2003 12:13:49 -0000
@@ -116,6 +116,7 @@
 Lars Hecking           address@hidden
 Lars J. Aas            address@hidden
 Laurent Morichetti     address@hidden
+Leo Davis              address@hidden
 Maciej Stachowiak      address@hidden
 Maciej W. Rozycki      address@hidden
 Manu Rouat             address@hidden
Index: tests/lex3.test
===================================================================
RCS file: /cvs/automake/automake/tests/lex3.test,v
retrieving revision 1.12
diff -u -r1.12 lex3.test
--- tests/lex3.test     8 Sep 2002 13:07:55 -0000       1.12
+++ tests/lex3.test     26 Feb 2003 12:13:49 -0000
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 1999, 2001, 2002  Free Software Foundation, Inc.
+# Copyright (C) 1999, 2001, 2002, 2003  Free Software Foundation, Inc.
 #
 # This file is part of GNU Automake.
 #
@@ -21,7 +21,7 @@
 # Test associated with PR 19.
 # From Matthew D. Langston.
 
-required='gcc gzip'
+required='gcc gzip flex'
 . ./defs || exit 1
 
 # Ignore user CFLAGS.
Index: tests/lex5.test
===================================================================
RCS file: /cvs/automake/automake/tests/lex5.test,v
retrieving revision 1.3.2.1
diff -u -r1.3.2.1 lex5.test
--- tests/lex5.test     30 Sep 2002 20:13:04 -0000      1.3.2.1
+++ tests/lex5.test     26 Feb 2003 12:13:49 -0000
@@ -1,5 +1,5 @@
 #! /bin/sh
-# Copyright (C) 2002  Free Software Foundation, Inc.
+# Copyright (C) 2002, 2003  Free Software Foundation, Inc.
 #
 # This file is part of GNU Automake.
 #
@@ -20,7 +20,7 @@
 
 # Test for subdir lexers.
 
-required='gcc GNUmake gzip'
+required='gcc GNUmake gzip flex'
 . ./defs || exit 1
 
 set -e

-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]