automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't punish non-DJGPP/non-Windows platforms..., rev. 3 [PATCH]


From: Richard Dawe
Subject: Re: Don't punish non-DJGPP/non-Windows platforms..., rev. 3 [PATCH]
Date: Fri, 04 Apr 2003 10:06:43 +0100

Hello.

Alexandre Duret-Lutz wrote:
[snip]
>  Richard> +AC_MSG_CHECKING([how many seconds we should wait after modifying a 
> file])
>  Richard> +case $build in
>  Richard> +  *-pc-msdosdjgpp) result=5;;
>  Richard> +  *)               result=2;;
>  Richard> +esac
>  Richard> +AC_SUBST([MODIFICATION_DELAY], [$result])
>  Richard> AC_MSG_RESULT([$result])
> 
> It's less armored, but it's still autotankish.  Please strip out
> the AC_MSG_CHECKING and AC_MSG_RESULT for the reason I gave in
> my previous message.  This is not a check.

Sorry I missed that, when I was updating the patch.

I will do that, before committing.

> The check was done AC_CANONICAL_BUILD and you are just exploiting its
> result. You might as well rename $result as $MODIFICATION_DELAY, BTW.

I will do that, before committing.

> [...]
> 
> Sorry for the slow throughput and for being a pest.  I expect to
> have more time next week.  (And I'm happy to see people willing
> to help even if that might not sound so from my wording.)

FWIW I have the impression that you appreciate help! It takes a lot to put me
off, so if you want that, you'll have to try harder. ;)

Thanks, bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]