automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Automake::Config


From: Richard Dawe
Subject: Re: Automake::Config
Date: Wed, 06 Aug 2003 22:32:06 +0100

Hello.

Alexandre Duret-Lutz wrote:
[snip]
> So here we are.  This patch introduces a config.h equivalent:
> Automake::Config, so that these variables are substituted in one
> accessible place.
[snip]

No idea about the code, but I think there's a small mistake below:

> Index: Makefile.am
> ===================================================================
> RCS file: /cvs/automake/automake/Makefile.am,v
> retrieving revision 1.216
> diff -u -r1.216 Makefile.am
> --- Makefile.am 29 Jul 2003 20:32:31 -0000      1.216
> +++ Makefile.am 5 Aug 2003 19:56:25 -0000
[snip]
> @@ -97,7 +101,7 @@
>  ## This check avoids accidental configure substitutions in the source.
>  ## There are exactly 8 lines that should be modified.  This works out
>  ## to 28 lines of diffs.

         ^^
Shouldn't this be 20 now, given:

> -       @if test `diff $(srcdir)/automake.in automake | wc -l` -ne 28; then \
> +       @if test `diff $(srcdir)/automake.in automake | wc -l` -ne 20; then \
>           echo "found too many diffs between automake.in and automake"; 1>&2; 
> \
>           diff -c $(srcdir)/automake.in automake; \
>           exit 1; \
[snip]

Bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]




reply via email to

[Prev in Thread] Current Thread [Next in Thread]