automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Possible bug in Variable.pm (Mailing to proper address)


From: Alexandre Duret-Lutz
Subject: Re: Possible bug in Variable.pm (Mailing to proper address)
Date: Mon, 12 Jul 2004 00:13:04 +0200
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux)

>>> "Ray" == Ray Simard <address@hidden> writes:

 Ray> Hello!

 Ray> I saw something in the Automake Variable.pm code that
 Ray> looks like a bug. Here it is in unified-diff form.

Good catch, thank you!  

I'm installing it as follows.

(Please do send ChangeLog entries along patches against GNU
projects.)

2004-07-12  Ray Simard  <address@hidden>  (tiny change)

        * lib/Automake/Variable.pm (define): Fix precondition check.

Index: lib/Automake/Variable.pm
===================================================================
RCS file: /cvs/automake/automake/lib/Automake/Variable.pm,v
retrieving revision 1.34
diff -u -r1.34 Variable.pm
--- lib/Automake/Variable.pm    22 May 2004 07:19:35 -0000      1.34
+++ lib/Automake/Variable.pm    11 Jul 2004 22:10:21 -0000
@@ -791,7 +791,7 @@
   my ($var, $owner, $type, $cond, $value, $comment, $where, $pretty) = @_;
 
   prog_error "$cond is not a reference"
-    unless ref $where;
+    unless ref $cond;
 
   prog_error "$where is not a reference"
     unless ref $where;
-- 
Alexandre Duret-Lutz





reply via email to

[Prev in Thread] Current Thread [Next in Thread]