automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: FYI: fix race condition in elisp's recover rule


From: Stepan Kasal
Subject: Re: FYI: fix race condition in elisp's recover rule
Date: Thu, 31 Mar 2005 10:26:55 +0200
User-agent: Mutt/1.4.1i

Hello Alexandre,

thank you for this.  I read the patch and noticed one problem:

Previously, the sentence

   Using a dedicated witness like this is very handy when the list of
   output files is not known beforehand.  

came immediately after data.stamp was introduced, so it was clear what
is meant by the "witness like this".  Now, when you inserted the explanation
of the data.lock technique, things are no longer so clear.
I'm not sure how this should be solved; one attempt ispart of the attached
*-typo1.patch.

Two patches are attached to this mail:

automake-20050331-typo1.patch

A few unrelated typos are fixed here, including a possible fix to the issue
described above.

automake-20050331-typo2.patch

I think that when the phrase "for instance" is used to introduce a sentence,
it should be used with a comma.  This patch implements this.
To be applied after the *-typo1.patch.

Please note that there are cases where I haven't added the comma, like the
following:
    For instance one directory per program, per library or per module.

There is no verb, so it's not a sentence, so I think comma is not needed here.

Have a nice day,
        Stepan Kasal

Attachment: automake-20050331-typo1.patch
Description: Text document

Attachment: automake-20050331-typo2.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]