[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

ansi2knr and pmake

From: Ralf Wildenhues
Subject: ansi2knr and pmake
Date: Tue, 2 May 2006 20:14:39 +0200
User-agent: Mutt/1.5.11+cvs20060403

With pmake (BSD make) on GNU/Linux, some failures
| FAIL: ansi6.test
| FAIL: ansi7.test
| FAIL: ansi9.test
| FAIL: ansi10.test

happen because the `./ansi2knr' program doesn't match the `ansi2knr'
rule, thus pmake chooses its internal rule to compile C sources:
| gcc -g -O2   -o ./ansi2knr ./ansi2knr.c

thus the $(DEFS) don't get picked up:
| ./ansi2knr.c:184: error: conflicting types for 'malloc'
| ./ansi2knr.c:184: error: conflicting types for 'malloc'

I think the patch below fixes that.  The issue also happens on BSD
systems, except that there it just doesn't happen to turn into a test
failure due to less conflicting malloc declarations:
| ./ansi2knr.c:184: warning: conflicting types for built-in function 'malloc'

OK?  Or do we give up on KnR anyway and remove ansi2knr and its support


        * lib/am/ (ansi2knr): Rename target as..
        (./ansi2knr): ..this, for BSD make.
        (%ANSI2KNR-DIR%/ansi2knr): Adjust.

Index: lib/am/
RCS file: /cvs/automake/automake/lib/am/,v
retrieving revision 1.6
diff -u -r1.6
--- lib/am/  14 May 2005 20:28:51 -0000      1.6
+++ lib/am/  2 May 2006 18:10:28 -0000
@@ -29,14 +29,14 @@
 ANSI2KNR = %ANSI2KNR-DIR%/ansi2knr
-       cd %ANSI2KNR-DIR% && $(MAKE) $(AM_MAKEFLAGS) ansi2knr
+       cd %ANSI2KNR-DIR% && $(MAKE) $(AM_MAKEFLAGS) ./ansi2knr
 else !%?ANSI2KNR-DIR%
 ## Substitution from AM_C_PROTOTYPES.  This makes it be built only when
 ## necessary.
-ansi2knr: ansi2knr.$(OBJEXT)
+./ansi2knr: ansi2knr.$(OBJEXT)
        $(LINK) ansi2knr.$(OBJEXT) $(LIBS)
 ansi2knr.$(OBJEXT): $(CONFIG_HEADER)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]