[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Creating subdirs of distdir

From: Ralf Wildenhues
Subject: Re: Creating subdirs of distdir
Date: Sun, 14 May 2006 19:32:57 +0200
User-agent: Mutt/1.5.11+cvs20060403

Hi Stepan,

* Stepan Kasal wrote on Sun, May 14, 2006 at 04:58:57PM CEST:
> I have two proposals:
> First is simple: during `make dist', changing $(mkdir_p) to
>       test -d .. || $(mkdir_p) ..
> would speed up things.

> As the second proposal, I have the radical idea of removing the
> DISTDIRS computation completely.  It is simple, and with my proposed
> patch, it calls mkdir only once for each subdirectory.

> Yes, the DISTDIRS method is slightly more effective, but I don't
> think it's worth the amount of code which is needed, and which would
> be needed to fix this for conditionals.

Hmm.  You could "sort -u" the list of directories to create at "make
dist" time.  That way you spend one more process at the gain of killing
all the stat(3) calls that your "test -d" will make.

IOW: do you have any numbers to support your increased efficiency?  How
much "value" (readability; speedup?) does the DISTDIRS simplification
get?  (This is not to argue against the patch, but sheer curiosity.)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]