Re: [patch] ccnoco.test: ignore all user settings, not just common ones

[Mike Frysinger]

On Wednesday 02 January 2008, Ralf Wildenhues wrote:
> * Mike Frysinger wrote on Mon, Dec 31, 2007 at 07:25:51PM CET:
> > if you have custom CPPFLAGS or LDFLAGS set, the ccnoco test can fail.  in
> > the spirit of the existing code which resets CFLAGS, this patch does the
> > same for CPPFLAGS and LDFLAGS.
>
> Thanks for the report and patch.  Could you please give an example where
> the test fails, so that it can be mentioned in the change, and we can
> decide whether to apply the change also to other tests of this set?
>   grep -l "^CFLAGS=" tests/*.test

the setup in question had "-Wl,--sort-common" in LDFLAGS and since "Mycomp" 
has a glob like:
*-o*-c*
this catches the case of:
$(CC) -o conftest -Wl,--sort-common

if you give credit, please include "Carsten Lohrke <address@hidden>" as he 
is the one who hit this and did original analysis.  thanks!
-mike

signature.asc
Description: This is a digitally signed message part.