Re: [patch] ccnoco.test: ignore all user settings, not just common ones

[Ralf Wildenhues]

Hello Mike,

* Mike Frysinger wrote on Wed, Jan 02, 2008 at 10:49:57PM CET:
> On Wednesday 02 January 2008, Ralf Wildenhues wrote:
> >
> > Thanks for the report and patch.  Could you please give an example where
> > the test fails, so that it can be mentioned in the change, and we can
> > decide whether to apply the change also to other tests of this set?
> >   grep -l "^CFLAGS=" tests/*.test
> 
> the setup in question had "-Wl,--sort-common" in LDFLAGS and since "Mycomp" 
> has a glob like:
> *-o*-c*
> this catches the case of:
> $(CC) -o conftest -Wl,--sort-common
> 
> if you give credit, please include "Carsten Lohrke <address@hidden>" as he 
> is the one who hit this and did original analysis.  thanks!

OK.  I'm a bit wary throwing out all flags, as they may just be
necessary for the compiler to work.  So I'm making the test more
specific instead.  I'm applying this patch to master and branch-1-10.  

Cheers, and thanks again,
Ralf

        * tests/ccnoco.test (Mycomp): Use a tighter match for -c -o,
        to avoid matching for example `LDFLAGS=-Wl,--sort-common'.
        * THANKS: Update.
        Report and analysis by Carsten Lohrke and Mike Frysinger.

diff --git a/tests/ccnoco.test b/tests/ccnoco.test
index 8b37fe8..50b5271 100755
--- a/tests/ccnoco.test
+++ b/tests/ccnoco.test
@@ -57,8 +57,8 @@ END
 cat > Mycomp << 'END'
 #!/bin/sh
 
-case "$@" in
- *-c*-o* | *-o*-c*)
+case " "$* in
+ *\ -c*\ -o* | *\ -o*\ -c*)
     exit 1
     ;;
 esac