[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: duplicate automake runs? [patch: Makefile.in in subdir not generated
Re: duplicate automake runs? [patch: Makefile.in in subdir not generated]
Thu, 28 Aug 2008 20:33:00 +0200
* Ilya N. Golubev wrote on Thu, Aug 28, 2008 at 05:40:03PM CEST:
> > causes duplicate automake reruns in the common case
> > where toplevel Makefile.am is updated.
> Explicitly tried avoid that, and stated that in change log entry:
> > Added elimination of
> > duplicate `$(AUTOMAKE)' invocation.
Except my testing showed that your patch doesn't always avoid it.
That's why I wrote the test case. Please try the testcase with
your patch, and you will see that it fails. If it doesn't fail,
then I would like to see VERBOSE=yes output of the succeeding test.
> Even if that still happens, would rather allow for that. For automake
> it is not considered better to be broken than to be slow, is it?
Of course slow is better than broken. However, as far as I can see,
my patch fixes the failure for good, *and* avoids duplicate automake
reruns. Best of both worlds! :-) Or do you see any issue with it?