automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

parallel-tests: let VERBOSE=yes output appear before summary.


From: Ralf Wildenhues
Subject: parallel-tests: let VERBOSE=yes output appear before summary.
Date: Fri, 10 Apr 2009 13:35:44 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

I noticed that VERBOSE=yes output is a bit confusing when you only look
at the end afterwards: the summary is posted before the per-test output
but not afterwards.  Since test-suite.log starts with summary-like
output anyway, reversing that order makes things much nicer.  :-)

Pushed to 'next'.

Cheers,
Ralf

    parallel-tests: let VERBOSE=yes output appear before summary.
    
    * lib/am/check.am ($(TEST_SUITE_LOG)): In `VERBOSE=yes' mode,
    output contents of `$(TEST_SUITE_LOG)' before, rather than after
    the test suite summary.  This ensures that the email address
    appears near the end of the output; also, the log file already
    starts with a result summary anyway.

diff --git a/lib/am/check.am b/lib/am/check.am
index f0917a0..00b80d6 100644
--- a/lib/am/check.am
+++ b/lib/am/check.am
@@ -208,6 +208,7 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
            msg="$${msg}Please report to $(PACKAGE_BUGREPORT).  ";      \
          fi;                                                           \
        fi;                                                             \
+       test x"$$VERBOSE" = x || $$exit || cat $(TEST_SUITE_LOG);       \
        $(am__tty_colors);                                              \
        if $$exit; then                                                 \
          echo $(ECHO_N) "$$grn$(ECHO_C)";                              \
@@ -216,7 +217,6 @@ $(TEST_SUITE_LOG): $(TEST_LOGS)
        fi;                                                             \
        echo "$$msg" | $(am__text_box);                                 \
        echo $(ECHO_N) "$$std$(ECHO_C)";                                \
-       test x"$$VERBOSE" = x || $$exit || cat $(TEST_SUITE_LOG);       \
        $$exit
 
 RECHECK_LOGS = $(TEST_LOGS)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]