automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCHES] Remove useless executable bits from two files


From: Stefano Lattarini
Subject: [PATCHES] Remove useless executable bits from two files
Date: Fri, 4 Dec 2009 20:50:46 +0100
User-agent: KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.2; i686; ; )

Hello automakers.

I noticed that at least two files in the automake tree have the 
executable bit on, without really needing it:
  - the committed file `automake.in' (note that the similar file
    `aclocal.in' is not executable)
  - the generated file `lib/Automake/Config.pm'

The two very simple attached patches correct these glitches.

This is admittedly nitpicking, but I think that the fewer warts the 
better. I hope you'll agree with me.

Regards,
     Stefano
From a5393aff1a019ab270b2096a12c2ac0cdd66872e Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Fri, 4 Dec 2009 18:40:50 +0100
Subject: [PATCH] Don't make the generated Automake's Config.pm executable.

* lib/Automake/Makefile.am (Config.pm): Don't make the generated
`Config.pm' file executable.
---
 ChangeLog                |    6 ++++++
 lib/Automake/Makefile.am |    1 -
 lib/Automake/Makefile.in |    1 -
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2fe0566..93c9dec 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-12-04  Stefano Lattarini  <address@hidden>
+
+       Don't make the generated Automake's Config.pm executable.
+       * lib/Automake/Makefile.am (Config.pm): Don't make the generated
+       `Config.pm' file executable.
+
 2009-10-18  Ralf Wildenhues  <address@hidden>
 
        Simplify Variable::_check_ambiguous_condition.
diff --git a/lib/Automake/Makefile.am b/lib/Automake/Makefile.am
index b4f5fbd..ff5b950 100644
--- a/lib/Automake/Makefile.am
+++ b/lib/Automake/Makefile.am
@@ -64,7 +64,6 @@ do_subst = in=`echo $@ | sed 's/\.[^.]*$$//'`; sed \
 Config.pm: Config.in Makefile
        $(AM_V_GEN)rm -f Config.tmp Config.pm
        $(AM_V_at)$(do_subst) $(srcdir)/Config.in >Config.tmp
-       $(AM_V_at)chmod +x Config.tmp
        $(AM_V_at)chmod a-w Config.tmp
        $(AM_V_at)mv -f Config.tmp Config.pm
 
diff --git a/lib/Automake/Makefile.in b/lib/Automake/Makefile.in
index 8f4ec8a..cace114 100644
--- a/lib/Automake/Makefile.in
+++ b/lib/Automake/Makefile.in
@@ -661,7 +661,6 @@ uninstall-am: uninstall-dist_perllibDATA 
uninstall-nodist_perllibDATA
 Config.pm: Config.in Makefile
        $(AM_V_GEN)rm -f Config.tmp Config.pm
        $(AM_V_at)$(do_subst) $(srcdir)/Config.in >Config.tmp
-       $(AM_V_at)chmod +x Config.tmp
        $(AM_V_at)chmod a-w Config.tmp
        $(AM_V_at)mv -f Config.tmp Config.pm
 
-- 
1.6.5

From 1c0066821e5e1ec07da6a43d1ec0405d2de522db Mon Sep 17 00:00:00 2001
From: Stefano Lattarini <address@hidden>
Date: Fri, 4 Dec 2009 18:15:57 +0100
Subject: [PATCH] Remove executable bit from automake.in

File `automake.in' is not meant to be executed (only to be
preprocessed into `automake'), so don't leave it executable.

* automake.in: Remove executable bit.
---
 ChangeLog   |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
 mode change 100755 => 100644 automake.in

diff --git a/ChangeLog b/ChangeLog
index 2fe0566..40a9c23 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-12-04  Stefano Lattarini  <address@hidden>
+
+       File `automake.in' is not meant to be executed (only to be
+       preprocessed into `automake'), so don't leave it executable.
+       * automake.in: Remove executable bit.
+
 2009-10-18  Ralf Wildenhues  <address@hidden>
 
        Simplify Variable::_check_ambiguous_condition.
diff --git a/automake.in b/automake.in
old mode 100755
new mode 100644
-- 
1.6.5


reply via email to

[Prev in Thread] Current Thread [Next in Thread]