Re: [PATCH 1/2] Avoid another use of `chmod -R'.

[Stefano Lattarini]

At Tuesday 30 March 2010, Ralf Wildenhues <address@hidden> 
wrote:
> Hi Stefano,
> 
> thanks for the patch.
> 
> * Stefano Lattarini wrote on Tue, Mar 30, 2010 at 05:52:21PM CEST:
> > * Makefile.am (path-check): To be safe, do not use `chmod -R' on
> > $(distdir) before removing it (as Solaris `chmod -R' touches
> > symlink targets).  Instead, use the cleanup strategy used in
> > distdir.am (which is also employed in tests/defs.in).
> 
> I'm not sure I understand.  We are not putting any symlinks into
> $(distdir), why would this be needed?
First, mostly for consistency with other cleanup rules (those in 
`tests/defs.in', `tests/Makefile.am' and `lib/am/distdir.am'), and 
second, to cater for the (admittedly very unlikely) case that a
dist-hook will be added that puts a symlink in $(distdir), or that a 
bug will be introduced that ends up putting a symlink in $(distdir)
somehow.

In the end, this patch should be seen mostly as a "cosmetic" one.  I 
should have stressed that better.

> In order for symlinks to end up in $(distdir), you have to have a
> dist-hook or similar rule, because normal distributed symlinks in
>  the source tree will be expanded as regular files in $(distdir).
I must admit that I forgot the existence this "symlink-resolving" 
feature...

By the way, is it tested in the testsuite?  I couldn't find anything 
relevant by grepping the test scripts.

Regards,
    Stefano