automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Use `set -e' in confsub.test (avoid false negatives).


From: Ralf Wildenhues
Subject: Re: Use `set -e' in confsub.test (avoid false negatives).
Date: Tue, 20 Apr 2010 21:01:05 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

* Stefano Lattarini wrote on Tue, Apr 20, 2010 at 12:22:48PM CEST:
> Mmhh... I thought that you had already applied this patch, but 
> perusing the git logs of latest master I saw that this is not the 
> case.
> 
> Thus I rebased the patches and amended them to follow your
> suggestions.  The new patches are attached.

Thanks.  I'm applying 1/2 but not 2/2, I don't see the advantage in
changes that are noise.

>  PATCH [1/2]  Use `set -e' in confsub.test (avoid false negatives).
> 
>   * tests/confsub.test: Enable shell `errexit' flag, and related
>     changes (this helps avoiding some possible minor false negatives).
>     Also, bumped copyright years.

>  [PATCH 2/2] Some cleanup and cosmetic changes in confsub.test.
> 
>   * tests/confsub.test: Prefer `echo' over `cat' to create one-line
>     data files, and prefer `:' over `cat' to create empty data files.

Cheers,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]