automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Make badopt.test stricter (by enabling `set -e').


From: Ralf Wildenhues
Subject: Re: [PATCH] Make badopt.test stricter (by enabling `set -e').
Date: Sun, 25 Apr 2010 17:59:45 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 02:42:04PM CEST:
> At Sunday 25 April 2010, Ralf Wildenhues wrote:
> > For what it's worth, since git this issue should be fairly moot.
> > You can keep branches for a long time, and merge them into your
> > devel-branch-du-jour for testing them.  You can squash stuff into
> > them.  You can rebase them if you think that would help you, but
> > frankly, don't.  Just keep the patch from where you developed it,
> > unless it requires newer stuff.  When that happens, you can either
> > rebase, or merge maint (or whatever else newer you need) into your
> > branch and continue.  Only then, you would need to start publishing
> > trees or git bundles, so that merges are handled upstream.
> >
> Well, this is exactly what I usually do, and is also very convenient 
> for me; but I tought that it would have been less convient *for you* 
> to have bigger patches to review, especially if these patches had been 
> written incrementally.  Apparently this is not the case: thanks for 
> claryfing this out.

Well, that is the case if the patches do conceptually different things.
But not for patches that do the same thing.  In fact, for this kind of
patch I might just trust that you did check that they are ok.

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 02:49:22PM CEST:
> That said, I think this patch should be applied as-is, since it fixes a 
> potential false negative in the tests.

OK, for maint.

Thanks,
Ralf




reply via email to

[Prev in Thread] Current Thread [Next in Thread]