Re: [PATCH] Add tests about support of wildcards in EXTRA_DIST

[Ralf Wildenhues]

Long ago:
<http://lists.gnu.org/archive/html/automake-patches/2010-02/msg00017.html>

* Ralf Wildenhues wrote on Sat, Feb 20, 2010 at 05:42:30PM CET:
> * Stefano Lattarini wrote on Sat, Feb 20, 2010 at 04:49:37PM CET:
> > I've written a small patch adding some tests.  Note that they are mostly
> > tentative, and might also be inclomplete, since I have always used the
> > "dist" features of Automake only in the most basic ways.  But incomplete
> > is better than missing, I think.
> 
> Thanks!  Tested with GNU and FreeBSD make, queued to maint, for
> branch-1.11 and master.  We'll see if other makes have problems.
> 
> > From 5f22886459c360e43ecd762efb058c53c0691bbb Mon Sep 17 00:00:00 2001
> > From: Stefano Lattarini <address@hidden>
> > Date: Sat, 20 Feb 2010 16:41:56 +0100
> > Subject: [PATCH] Add tests about support of wildcards in EXTRA_DIST.
> > 
> > * tests/extra10.test: New test, check basic support of wildcards
> > in EXTRA_DIST.
> > * tests/extra11.test: New test, check more complex usage of
> > wildcards in EXTRA_DIST.
> > * tests/extra11.test: New test, check usage of wildcards in
> > EXTRA_DIST when $builddir != $srcdir.
> > * tests/Makefile.am (TESTS): Updated accordingly.
> > Necessity of these new tests suggested by Braden McDaniel
> > <address@hidden> and Ralf Wildenhues <address@hidden>

Unfortunately that turned out to be too optimistic.  I'm pushing this
followup to maint.  Tested on NetBSD 5.99.29 and the pmake package of
Debian.

Cheers,
Ralf

    Wildcards are not portable to NetBSD make.
    
    * doc/automake.texi (Wildcards): Document portability issue.
    * tests/extra10.test, tests/extra11.test, tests/extra12.test:
    Require GNU make.

diff --git a/doc/automake.texi b/doc/automake.texi
index 48bf33a..9d400e9 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -10644,6 +10644,11 @@ even though a file is missing. By listing files, 
@samp{make dist}
 @emph{will} complain.
 
 @item
+Wildcards are not portable to some non-GNU @command{make} implementations,
+e.g., NetBSD @command{make} will not expand globs such as @samp{*} in
+prerequisites of a target.
+
address@hidden
 Finally, it's really hard to @emph{forget} to add a file to
 @file{Makefile.am}: files that are not listed in @file{Makefile.am} are
 not compiled or installed, so you can't even test them.
diff --git a/tests/extra10.test b/tests/extra10.test
index 16d06a3..7bd6556 100755
--- a/tests/extra10.test
+++ b/tests/extra10.test
@@ -17,6 +17,7 @@
 # Check that wildcards in EXTRA_DIST are honoured.
 # Suggested by observations from Braden McDaniel.
 
+required=GNUmake
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/extra11.test b/tests/extra11.test
index 14dda42..a0c55ca 100755
--- a/tests/extra11.test
+++ b/tests/extra11.test
@@ -17,6 +17,7 @@
 # Check for more complex usage of wildcards in EXTRA_DIST.
 # Suggested by observations from Braden McDaniel.
 
+required=GNUmake
 . ./defs || Exit 1
 
 set -e
diff --git a/tests/extra12.test b/tests/extra12.test
index 72b918c..db3bcc7 100755
--- a/tests/extra12.test
+++ b/tests/extra12.test
@@ -18,6 +18,7 @@
 # $srcdir != $builddir, if properly declared.
 # Suggested by observations from Braden McDaniel.
 
+required=GNUmake
 . ./defs || Exit 1
 
 set -e