automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: git-version-gen not EBCDIC compatible


From: Ralf Wildenhues
Subject: Re: git-version-gen not EBCDIC compatible
Date: Sun, 23 May 2010 16:46:02 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

* Eric Blake wrote on Mon, Apr 26, 2010 at 05:44:35PM CEST:
> Thanks for the report.  I'll push this patch shortly for
> git-version-gen, but there are other culprits (MODULES.html.sh,
> gnupload, m4/get{delim,line}.m4, m4/javacomp.m4, posix-modules) that are
> still ascii-specific.

Thanks for the report.  I'm fixing gnupload in automake (maint branch)
as follows, and adding Steve to THANKS.

Cheers,
Ralf

    Make gnupload portable to EBCDIC hosts.
    
    * lib/gnupload: Use literal newline as argument for 'tr' rather
    than \015, for EBCDIC hosts.  Also, avoid unportable nested
    double-quotes and backquotes.
    * THANKS: Update.
    Report from Eric Blake and Steve Goetze via gnulib.

index d445075..5036752 100755
--- a/lib/gnupload
+++ b/lib/gnupload
@@ -1,7 +1,7 @@
 #!/bin/sh
 # Sign files and upload them.
 
-scriptversion=2010-02-08.07; # UTC
+scriptversion=2010-05-23.15; # UTC
 
 # Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Free Software
 # Foundation, Inc.
@@ -32,6 +32,8 @@ delete_files=
 delete_symlinks=
 collect_var=
 dbg=
+nl='
+'
 
 usage="Usage: $0 [OPTION]... [CMD] FILE... [[CMD] FILE...]
 
@@ -109,7 +111,8 @@ Send patches to <address@hidden>."
 # Read local configuration file
 if test -r "$conffile"; then
   echo "$0: Reading configuration file $conffile"
-  eval set x "`sed 's/#.*$//;/^$/d' \"$conffile\" | tr '\012\015' '  '` 
\"address@hidden""
+  conf=`sed 's/#.*$//;/^$/d' "$conffile" | tr "\015$nl" '  '`
+  eval set x "$conf \"address@hidden""
   shift
 fi
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]