[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer aroun

From: Ralf Wildenhues
Subject: Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.
Date: Sun, 6 Jun 2010 21:38:08 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

* Stefano Lattarini wrote on Sun, Jun 06, 2010 at 07:50:57PM CEST:
> At Sunday 06 June 2010, Ralf Wildenhues wrote:
> > 
> > Thanks, and sorry for not having rerun the complete testsuite
> >  before pushing the original patch.
> Well, I should say "sorry" for not having tested the patch thoroughly.

The patch is still not right, so I'm not pushing it.  A generated test
foo-p.test now needs to depend upon foo.test, this is not reflected in
the makefile.

Either we rewrite so that it is idempotent and sourced twice,
or sets only the needed variables the first time it is sourced.
Alternatively, it seems viable to just revert this patch mini series
un-aply titled "bikeshedding" in the first place.  ;-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]