automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Improve declaration of dependencies in the testsuite.


From: Ralf Wildenhues
Subject: Re: [PATCH] Improve declaration of dependencies in the testsuite.
Date: Tue, 8 Jun 2010 20:35:13 +0200
User-agent: Mutt/1.5.20 (2009-10-28)

* Ralf Wildenhues wrote on Mon, Jun 07, 2010 at 11:23:23PM CEST:
>       Improve declaration of dependencies in the testsuite.
>       * tests/Makefile.am (check_SCRIPTS): Remove.  Instead, let ...
>       ($(TEST_LOGS)): ... all test logs depend on the scripts.
>       * test/gen-parallel-tests: For each parallel test foo-p.test,
>       let `foo-p.log' also depend on `foo.test', since it is sourced.

Hmpf.  There is a practical downside to this.  When working on defs.in,
I would often quickly like to see if my changes improved things.  Before
this patch, and assuming that my change didn't introduce regressions,
a quick check was possible with
  make recheck                  # retry all failed tests
  make check RECHECK_LOGS=      # try all yet-untried tests

With this patch, the second command will rerun all tests.  Sure, before
I push a patch, the latter is the right thing to do, but during testing,
it can be a bit annoying.

Still, we are advocating this approach, and I still think that it is
the right thing for files that only a subset of tests depend upon;
eating our own dog food serves us right.

I wonder why I can't use
  gmake --assume-old=defs check RECHECK_LOGS=

to work around this, though.  Must be due to the make recursions.

Cheers,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]