[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Minor improvements in bootstrap script.
From: |
Eric Blake |
Subject: |
Re: [PATCH] Minor improvements in bootstrap script. |
Date: |
Wed, 09 Jun 2010 18:53:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Lightning/1.0b2pre Mnenhy/0.8.2 Thunderbird/3.0.4 |
On 06/09/2010 05:01 PM, Stefano Lattarini wrote:
> * bootstrap: Do not create a temporary file to find the PATH
> separator. Consistently use two-spaces indentation. Also,
> cosmetic improvement to comments, and bumped copyright years.
> -# Find the path separator
> -echo "#! /bin/sh" >boot$$.sh
> -echo "exit 0" >>boot$$.sh
> -chmod +x boot$$.sh
> -if (PATH="/nonexistent;."; boot$$.sh) >/dev/null 2>&1; then
> +# Find the path separator.
> +if (PATH="/bin;/nonexistent"; export PATH; sh -c :) >/dev/null 2>&1; then
Will that always work on mingw, where you are not guaranteed the
existence of /bin/sh? Then again, mingw is one of the platforms where
you want the path separator to be detected as ; rather than :.
--
Eric Blake address@hidden +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/09
- Re: [PATCH] Minor improvements in bootstrap script.,
Eric Blake <=
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Eric Blake, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Ralf Wildenhues, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/10
- Re: [PATCH] Minor improvements in bootstrap script., Ralf Wildenhues, 2010/06/11
- Re: [PATCH] Minor improvements in bootstrap script., Stefano Lattarini, 2010/06/11