[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Enable `errexit' shell flag in various tests (again).
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] Enable `errexit' shell flag in various tests (again). |
Date: |
Sat, 12 Jun 2010 12:35:36 +0200 |
User-agent: |
Mutt/1.5.20 (2009-10-28) |
Hi Stefano,
* Stefano Lattarini wrote on Fri, Jun 11, 2010 at 05:30:57PM CEST:
> Enable `errexit' shell flag in various tests.
>
> * tests/backsl.test: Enable the `errexit' shell flag, and
> related changes.
> * tests/backsl2.test: Likewise.
> * tests/block.test: Likewise.
> * tests/canon2.test: Likewise.
> * tests/canon4.test: Likewise.
> * tests/comment2.test: Likewise.
> * tests/condlib.test: Likewise.
> * tests/cond15.test: Likewise, and prefer $FGREP over grep.
> * tests/canon3.test: Likewise. Also, avoid to create an useless
> dummy source file.
> * tests/acoutpt2.test: Enable the `errexit' shell flag, and some
> related changes. Do some cosmetic improvements in the generated
> `configure.in' file.
> * tests/cond4.test: Likewise.
> * tests/cond14.test: Likewise.
> * tests/condinc.test: Likewise.
> * tests/cond7.test: Likewise. Also, remove useless setting of
> AUTOMAKE_OPTIONS to `foreign' in the generated Makefile.am.
> * tests/ansi.test: Enable the `errexit' shell flag, and related
> changes. Extended, esp. by running autoconf, ./configure and
> make, and by looking into the distdir.
This patch is good for maint, thanks.
> -cat > configure.in << 'END'
> -AC_INIT
> -AM_INIT_AUTOMAKE(nonesuch, nonesuch)
> +set -e
> +
> +cat > configure.in <<END
> +AC_INIT([$me], [1.0])
> +AM_INIT_AUTOMAKE
Just be sure that we keep at least one instance of the old
AM_INIT_AUTOMAKE(pkg, version,...) and the old AC_OUTPUT(files...)
calls, so this code path is still covered adequately.
Cheers,
Ralf