[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCHES] Minor cleanup and/or cosmetic patches for the testsuite. |
Date: |
Sat, 12 Jun 2010 20:03:59 +0200 |
User-agent: |
KMail/1.12.1 (Linux/2.6.30-2-686; KDE/4.3.4; i686; ; ) |
At Saturday 12 June 2010, Ralf Wildenhues wrote:
> Hi Stefano,
>
> * Stefano Lattarini wrote on Sat, Jun 12, 2010 at 07:16:02PM CEST:
> > Here I present four simple patches that were originally part of
> > my patch series on the refactoring of 'tests/defs'. But they are
> > mostly indipendent from that series, which (by the way) is
> > already growing way too long. So I though it convenient and
> > appropriate to seperated them, and post them before the rest of
> > the series.
>
> Thanks. 1-3 are ok, I will commit them later; 4 is not, because
> it will do the wrong thing with, say,
> AUTOUPDATE='autoupdate --verbose'.
You're righ :-(
Originally, I wrote the patch during the refactoring of 'tests/defs',
because I needed to know which test(s) required what, and a
requirement of `$2' wasn't very clear...
I guess we should just drop this patch, or, better again, substutite
it with one adding a proper comment about why the `set' hack is
required.
Regards,
Stefano