Re: pr-msvc-support merge

[Peter Rosin]

Hi Chuck,

Den 2010-06-22 14:04 skrev Charles Wilson:
> On 6/22/2010 7:53 AM, Peter Rosin wrote:
> > I added compile5.test. I don't think $build is part of the equation
> > for the purpose of this test, and the only supported $host at this
> > point is mingw. Is it what you had in mind?
>
> Well, if $build is cygwin, then it'll work, because cygwin always has
> cygcheck.  If $build is mingw (actually "msys" in its normal 'pretend
> I'm mingw' mode) then it'll work, because cmd always exists, and sed is
> part of the base msys installation.
>
> However, if $build is anything else, then it'll work IF and only IF
> winepath is present.  That's not a given.  I don't think the test should
> FAIL just because wine is not installed; I think it should be skipped.

Ok, compile5 now skips if not on mingw/cygwin and winepath is not present.

> Finally, if $host is anything other than $mingw, then the tests should
> be skipped, too.  Right?

Right, but that was already the case I think.

Thanks for reviewing!

Cheers,
Peter

cl-wrapper-6.patch
Description: Source code patch