[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.

From: Stefano Lattarini
Subject: Re: [PATCH] Modernize, improve and/or extend tests `colon*.test.
Date: Sun, 8 Aug 2010 16:38:08 +0200
User-agent: KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; )

At Sunday 08 August 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Thu, Aug 05, 2010 at 01:54:20PM CEST:
> > Ping on this?  It seems to me that most issues with this patch
> > had already been solved, so it's probably a pity to let it
> > bitrotting here...
> Well, I'd prefer the extract_dependencies script approach
I like the idea, too, but as I said I'd prefer to leave for a later 
> which would be more correct and not the complicated perl script
> which wasn't as correct.
Why not as correct?

You said in a previous mail:
   A shell function in 'extract_makefile_deps TARGET FILE'
   that contains a sed script similar to extract_makefile_var that
   does what you want, and respects backslash-newline?
But why should that function preserve backslash-newline occurrences?
Is not this an internal detail due to automatical line-wrapping by
Automake, which we should therefore ignore?

> And the relaxed file distribution test.  ;-)
Done (I said that I agreed with you on this): I squashed in this 

diff --git a/tests/colon5.test b/tests/colon5.test
index 26f10e4..c53910e 100755
--- a/tests/colon5.test
+++ b/tests/colon5.test
@@ -34,7 +34,7 @@ cat > <<'END'
 .PHONY: test
        case ' $(DIST_COMMON) ' in \
-         *' $(srcdir)/Makefile.dep '*) exit 0;; \
+         *' $(srcdir)/Makefile.dep '*|*' Makefile.dep '*) exit 0;; \
          *) exit 1;; \

> Thanks, and sorry for the delay,
> Ralf

Thanks for the review,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]